gnustep / apps-gworkspace

GWorkspace is GNUstep's Workspace Manager and offers a File Manager and an optional Desktop with associated services and tools.
http://www.gnustep.org
GNU General Public License v2.0
28 stars 14 forks source link

check uninitialized operation warnings #29

Closed rmottola closed 2 months ago

rmottola commented 2 months ago
FSNListView.m: In function '-[FSNListViewDataSource addColumn:]':
FSNListView.m:170:3: warning: passing argument 1 of 'initWithIdentifier:' from distinct Objective-C type
  170 |   NSTableColumn *column = [[NSTableColumn alloc] initWithIdentifier: identifier];
      |   ^~~~~~~~~~~~~
FSNBrowserColumn.m: In function '-[FSNBrowserColumn(DraggingDestination) concludeDragOperation:]':
FSNBrowserColumn.m:1503:3: warning: 'operation' may be used uninitialized [-Wmaybe-uninitialized]
 1503 |   [opDict setObject: operation forKey: @"operation"];
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
FSNBrowserColumn.m:1433:13: note: 'operation' was declared here
 1433 |   NSString *operation, *source;
      |             ^~~~~~~~~
FSNIcon.m: In function '-[FSNIcon(DraggingDestination) concludeDragOperation:]':
FSNIcon.m:1830:7: warning: 'operation' may be used uninitialized [-Wmaybe-uninitialized]
 1830 |       [opDict setObject: operation forKey: @"operation"];
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
FSNIcon.m:1742:13: note: 'operation' was declared here
 1742 |   NSString *operation, *source;
      |             ^~~~~~~~~
FSNIconsView.m: In function '-[FSNIconsView(DraggingDestination) concludeDragOperation:]':
FSNIconsView.m:2272:3: warning: 'operation' may be used uninitialized [-Wmaybe-uninitialized]
 2272 |   [opDict setObject: operation forKey: @"operation"];
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
FSNIconsView.m:2199:13: note: 'operation' was declared here
 2199 |   NSString *operation, *source;
      |             ^~~~~~~~~
FSNBrowserColumn.m: In function '-[FSNBrowserColumn(DraggingDestination) concludeDragOperation:inMatrixCell:]':
FSNBrowserColumn.m:1749:7: warning: 'operation' may be used uninitialized [-Wmaybe-uninitialized]
 1749 |       [opDict setObject: operation forKey: @"operation"];
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
FSNBrowserColumn.m:1675:13: note: 'operation' was declared here
 1675 |   NSString *operation, *source;
      |             ^~~~~~~~~
FSNListView.m: In function '-[FSNListViewDataSource(DraggingDestination) listViewConcludeDragOperation:]':
FSNListView.m:2012:5: warning: 'operation' may be used uninitialized [-Wmaybe-uninitialized]
 2012 |     [opDict setObject: operation forKey: @"operation"];
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
FSNListView.m:1931:15: note: 'operation' was declared here
 1931 |     NSString *operation, *source;
      |  

Fiend/FiendLeaf.m: In function '-[FiendLeaf(DraggingDestination) concludeDragOperation:]':
Fiend/FiendLeaf.m:694:20: warning: 'operation' may be used uninitialized [-Wmaybe-uninitialized]
  693 |       [gw performFileOperation: operation source: source
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  694 |                    destination: [node path] files: files tag: &tag];
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fiend/FiendLeaf.m:654:17: note: 'operation' was declared here
rmottola commented 2 months ago

all operation related fixed.