objc_delete_weak_refs leaks one WeakRef block for every object that had weak references

gnustep / libobjc2

Objective-C runtime library intended for use with Clang.

http://www.gnustep.org/

MIT License

434 stars 118 forks source link

objc_delete_weak_refs leaks one WeakRef block for every object that had weak references #143

Closed DHowett-MSFT closed 4 years ago

DHowett-MSFT commented 4 years ago

objc_delete_weak_refs doesn't delete the ref that it finds in the map here:

https://github.com/gnustep/libobjc2/blob/59815ebc10191bda094579bf764103c13f15dceb/arc.mm#L869-L881

DHowett-MSFT commented 4 years ago

Sorry -- I got a little too trigger-happy here. Of course we can't delete WeakRef here: somebody is still holding on to it. It'll be cleaned up during destroyWeak.