search

gnustep / libobjc2

Objective-C runtime library intended for use with Clang.
http://www.gnustep.org/
MIT License
434 stars 118 forks source link

Operate on the real weak ref table when erasing an entry #145

Closed DHowett-MSFT closed 4 years ago

DHowett-MSFT commented 4 years ago

This pull request reverts 336d8a8 and fixes the underlying issue properly. The real meat of the change is in dd35187.

It's not strictly necessary that we revert 336d8a8, but it looks like it added some extra bookkeeping that we only needed because the map had dangling references. The tests that fail with 336d8a8 reverted pass with dd35187.

Fixes #144.