search

gnustep / libobjc2

Objective-C runtime library intended for use with Clang.
http://www.gnustep.org/
MIT License
434 stars 118 forks source link

Updated the class_copyMethodList #206

Closed mischievous closed 3 years ago

mischievous commented 3 years ago

Updated the class_copyMethodList to clear the stack garbage for outCount if preset before checking the class is null. This allows the pyobjc to mostly work.

davidchisnall commented 3 years ago

Thanks. This looks functionally correct, but please add the missing braces around the body of the if statement.

mischievous commented 3 years ago

So the automatic testing for gnustep.libobjc2 claimed it took longer than 60 minutes and was canceled... How do I resolve this issue?

davidchisnall commented 3 years ago

Thanks. There's an intermittent failure in one of the tests on 32-bit Windows.

mischievous commented 3 years ago

Tell me where to look to fix the test, and/or how to test it again and I will get it fixed.

davidchisnall commented 3 years ago

Sorry, to be clear: It's not your fault. The ManyManySelectors test allocates a lot of memory and, for some reason that I haven't been able to determine, sometimes on Win32 it times out rather than failing. I haven't been able to reproduce this, it seems to be something specific to how the Windows CI VMs work. It's intermittent and just rerunning the timed-out job typically fixes it. The timeout behaviour doesn't seem to happen anywhere else (this test can run out of memory on other systems, but then it fails).