Don't pass ANDROID_ARM_NEON when testing C++ runtime

gnustep / libobjc2

Objective-C runtime library intended for use with Clang.

http://www.gnustep.org/

MIT License

434 stars 118 forks source link

Don't pass ANDROID_ARM_NEON when testing C++ runtime #231

Closed triplef closed 2 years ago

triplef commented 2 years ago

Fixes building for Android arm64-v8a with NDK r25, which no longer supports this flag.

Since we were passing this unconditionally we were previously inadvertently disabling NEON support if the flag wasn't set, which is likely not what anyone would have wanted as NEON is enabled by default since NDK r21 and can no longer be disabled with r25.

Fixes https://github.com/gnustep/tools-android/issues/12.

triplef commented 2 years ago

@davidchisnall would it be ok to merge this? It’s currently blocking the tools-android CI to succeed.

For reference, these flags were originally added in #113.