search

gnustep / libobjc2

Objective-C runtime library intended for use with Clang.
http://www.gnustep.org/
MIT License
426 stars 116 forks source link

Prefer system-provided robin-map #248

Closed qmfrederik closed 6 months ago

qmfrederik commented 9 months ago

A lot of distributions ship with robin-map in their package management system, so it may not be a hard requirement to have robin-map as a submodule.

This PR updates the build system to search for tsl/robin_map.h and use that one if available; if not, fall back to the submodule.

davidchisnall commented 6 months ago

It would be good to have this in the next release. Do either of you want to incorporate the changes and update the PR?

qmfrederik commented 6 months ago

I've addressed the feedback (with some comments) and rebased on master. Let me know if there's anything else you need. Thanks!

qmfrederik commented 6 months ago

@davidchisnall Sorry for the noise. This should be good now. Can you kick off the GitHub CI for this PR, so we get the build signal on all systems?

davidchisnall commented 6 months ago

Thanks, looks great.