search

gnustep / libobjc2

Objective-C runtime library intended for use with Clang.
http://www.gnustep.org/
MIT License
426 stars 116 forks source link

Whitelist UnexpectedException test for all architectures and recommend libunwind in INSTALL #291

Open hmelder opened 2 months ago

hmelder commented 2 months ago

I am undecided about whether to add a try_compile to the CMakeLists.txt to automatically use CompilerRT and libunwind if they are available. This should exclude Windows and Android.

This PR should be merged after a fix for libgcc: _Unwind_RaiseException corrupts return value is implemented in GCC.

hmelder commented 2 months ago

On the other hand, automatic configuration is better than manually setting compile flags.

hmelder commented 2 months ago

What do you think @davidchisnall?

davidchisnall commented 2 months ago

I think this is the right thing (implicitly linking a non-default unwinded will break things for people), but I’d like CI to be green…

hmelder commented 2 months ago

but I’d like CI to be green…

We can use CompilerRT + libunwind in the CI

hmelder commented 2 months ago

I guess finding prebuild libunwind cross builds for ubuntu might be a bit difficult