search

gnustep / libs-back

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
50 stars 34 forks source link

Fix focus handling for a number of cases for WindowMaker #13

Closed trunkmaster closed 4 years ago

trunkmaster commented 4 years ago

During NEXTSPACE development I've managed to fix most (if not all) of focus related problems. Most tricky part was to make reliable focus handling on workspace switch. Most part of the changes are related to the TakeFocus atom that is specific to WindowMaker, AFAIK.

fredkiefer commented 4 years ago

Sorry, I looked at the code for quite some time. But I am not able to tell whether these changes are an improvement or not. Could somebody please test these changes on different window managers and report back some results?

The WM_TAKE_FOCUS atom ist not WindowMaker specific, it is defined here https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.7

trunkmaster commented 4 years ago

The improvement is in order of checks and extra checking. You are right WM_TAKE_FOCUS is not WindowMaker specific.

trunkmaster commented 4 years ago

@fredkiefer do you have any other objections?

trunkmaster commented 4 years ago

@fredkiefer ?

trunkmaster commented 4 years ago

Closing this for now.