gnustep / libs-back

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
50 stars 34 forks source link

Clang warnings fix for ART backend #16

Closed trunkmaster closed 4 years ago

trunkmaster commented 4 years ago

These changes are:

trunkmaster commented 4 years ago

Riccardo, do you have systems with old freetype library?

rmottola commented 4 years ago

Riccardo, do you have systems with old freetype library?

How old is "old". I Have only two systems where I still use art, one is current and up to date, the next I can check next week. < 2.1.1 ?

trunkmaster commented 4 years ago

On 18 Jan 2020, at 14:17, Riccardo notifications@github.com wrote:

Riccardo, do you have systems with old freetype library?

How old is "old". I Have only two systems where I still use art, one is current and up to date, the next I can check next week. < 2.1.1 ?

This line from ftfont.m :

if (FREETYPE_MAJOR==2) && ((FREETYPE_MINOR<1) || ((FREETYPE_MINOR==1) && (FREETYPE_PATCH<8)))

specifies version < 2.1 or < 2.1.8. Could you check if that system can work without art/ftfont-old.m file?

trunkmaster commented 4 years ago

@rmottola, any news?

rmottola commented 4 years ago

@trunkmaster I have some news. First, the old machine (it is the small MIPS minbook which Fred will remember and which for kernel reasons I cannot update to newer versions of Debian) has FreeType 2.2, so in "theory" there should be no issue! I rebuilt all gnustep "from scratch" natively, to test your patch. It builds, but fails. I noticed that libart is not netected, so I got a fallback on xlib. I need to investigate that. Xlib then fails with a crash (the reason I was using libart on this machine in the first place, there are issues with the system fonts. It used not to crash, but to draw no strings on the screen, I think this a "regression", but a different issue.

I will try to report back "why" libart is not being found, I will write to the mailing list, please bear some patience.

trunkmaster commented 4 years ago

@rmottola, no problem. Waiting for report on libart issue.