search

gnustep / libs-back

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
50 stars 34 forks source link

x11/XGServerWindow.m: removed WindowMaker appicon hack #29

Closed trunkmaster closed 4 years ago

trunkmaster commented 4 years ago

The removed code removed creates and maps zero-sized window in hope that WindowMaker will recognize app by this event and create app icon window. Although when application requests window for appicon through the -window:::: method call, it returns newly created and mapped window. This actually happens but application icon flickers between WM icon creation and application icon window appearance.

This fix based on the fact that root application window (ROOT) is mapped in -orderwindow::: and this is the event of application recognition by WindowMaker because it is a first application window that is mapped.

I've made tests on WindowMaker and NextSpace Workspace WM with ART and Cairo backends. Applications started with double-click is started with 'highlighted' icon and then normal icon without interim state - empty tile background with little white square at the center. It looks as more smooth application startup.

trunkmaster commented 4 years ago

Of course, it's my fault! Commented out code was removed.