gnustep / libs-back

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
50 stars 34 forks source link

Wayland backend xdg-surface and wrl-layer #33

Closed nongio closed 2 years ago

fredkiefer commented 3 years ago

This is way too much code for me to read through. As Wayland support is still experimental in GNUstep I would say we just take your code as it seems to work better than the previous one. It would be great if you could clean up the code a bit. That is remove commented out portions and try to stick to the GNUstep coding standard. (See http://www.gnustep.org/resources/documentation/Developer/CodingStandards/coding-standards.ps) Yes, this is horrible and really old. But having some standard saves us from discussing this every year.

nongio commented 3 years ago

thanks for checking it @fredkiefer I updated the code using clang-format with this configuration file: https://github.com/gnustep/libs-base/blob/master/.clang-format let me know if it can go like this

ivucica commented 2 years ago

nit: That should likely be November 2021, not November 2016.

sent from phone

gcasa commented 2 years ago

Merging this on behalf of @nongio since he doesn't have merge permission. I spoke with him via email.