search

gnustep / libs-base

The GNUstep Base Library is a library of general-purpose, non-graphical Objective C objects.
https://www.gnustep.org/
GNU General Public License v2.0
941 stars 283 forks source link

CI is red again #474

Open hmelder opened 2 days ago

hmelder commented 2 days ago

image

fredkiefer commented 2 days ago

Hi, this is great thank you for this clever fix. But this also raises a new question. GNUstep code as well as application code is full of IMP caching and my impression now is that that code also would be affected of the sam issue. Should we rewrite all that code to use the proper way to get the method implementation and advise users to do the same?

hmelder commented 1 day ago

Hi, this is great thank you for this clever fix. But this also raises a new question. GNUstep code as well as application code is full of IMP caching and my impression now is that that code also would be affected of the sam issue. Should we rewrite all that code to use the proper way to get the method implementation and advise users to do the same?

I think this is the wrong issue ^^

rfm commented 1 day ago

Yes, it probably is a bit of a misunderstanding, but I think the point is related to this issue:

I'm away from home at the moment, so this is from memory, but when cacheing IMPs we want to be sure we are looking them up correctly, so it is probably worth checking that the NSObject -methodForSelector: implementation is doing the right thing.