search

gnustep / libs-gui

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
279 stars 103 forks source link

Remove unused variables #247

Closed qmfrederik closed 8 months ago

qmfrederik commented 8 months ago

Suppresses a couple of build warnings (-Wunused-but-set-variable)

fredkiefer commented 8 months ago

I am fine with removing the unused variable from the second file.. In the first file things are different. Actually it would be great if we did use this variable and if the commented out code would be active. So instead of removing this variable we should try to get this code faster and reenable it again.

qmfrederik commented 8 months ago

@fredkiefer Thanks for reviewing this. I reduced the scope of this patch to focus on the first file only. You are probably right and the proper fix is to re-enable the commented out code, but that's a bit beyond the mindset of "let's see if there's low hanging fruit to reduce compiler warnings" I had when I opened these PRs.