search

gnustep / libs-gui

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
279 stars 103 forks source link

Minor renamings of some APIs #278

Open ethanc8 opened 5 months ago

ethanc8 commented 5 months ago

This commit implements Apple's renaming of some APIs, such as another enum NSProgressIndicatorStyle that Apple had renamed in order to allow it to be parsed by the Swift compiler, the new typedef typedef NSString *NSPasteboardType;, and the -[NSViewController view{Will|Did}{Appear|Disappear}] variants which take no arguments.

ethanc8 commented 5 months ago

It would be best to, instead of renaming them, do a similar version ifdef for the version of macOS this change was made in. We always want to be as backwards compatible as possible. It is okay in an enum for multiple names to be assigned the same value.

I did not rename any APIs -- I just added the new APIs, and the enums have been defined. I might need to add some guards around the new enum names, though.

gcasa commented 5 months ago

It would be best to, instead of renaming them, do a similar version ifdef for the version of macOS this change was made in. We always want to be as backwards compatible as possible. It is okay in an enum for multiple names to be assigned the same value.

I did not rename any APIs -- I just added the new APIs, and the enums have been defined. I might need to add some guards around the new enum names, though.

I apologize, I wasn't clear, this is what I meant. It's so that if someone is using a particular version of the API they don't have access to the enums under the new names.

fredkiefer commented 5 months ago

Could you please add the #ifdef that Gregory requested so we can merge this.

ethanc8 commented 5 months ago

Could you please add the #ifdef that Gregory requested so we can merge this.

I will do that tomorrow.