search

gnustep / libs-gui

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
279 stars 103 forks source link

Font Panel autosizing fix #299

Closed trunkmaster closed 1 month ago

trunkmaster commented 1 month ago

Fix autosizing of "Family" and "Typeface" browsers using different approach to NSView's default.

fredkiefer commented 1 month ago

I am not sure whether all this is needed or if it could be sufficient to set the correct resizing attributes on the existing views. What is it that you want to achieve?

trunkmaster commented 1 month ago

Sizing attributes are correct. Look at screenshots below, can you see the difference?

Initial panel size. VirtualBox_Fedora 39_05_10_2024_02_39_46

Resized without my fix VirtualBox_Fedora 39_05_10_2024_02_55_03

Resized with my fix VirtualBox_Fedora 39_05_10_2024_02_43_26

fredkiefer commented 1 month ago

Could you please try how the new resizing behaves when there is an accessoryView? This is not very common, we still need to support it.

trunkmaster commented 1 month ago

My change doesn't affect accessoryView, only browsers: familyBrowser, typefaceBrowser and sizeBrowser which are inside bottomSplit view.

However I can add and test accessoryView. What results do you expect from me: screenshots or something else?

fredkiefer commented 1 month ago

I don't need any proof, it is sufficient if you test it yourself.

trunkmaster commented 1 month ago

Looks good. VirtualBox_Fedora 39_09_10_2024_01_15_24 VirtualBox_Fedora 39_09_10_2024_01_17_21