gnustep / libs-gui

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
279 stars 103 forks source link

Fix issue with nsmenu items blocking the GUI #315

Closed johnathan-becker closed 1 week ago

johnathan-becker commented 3 weeks ago

This MR fixes an issue where when you click item an NSMenuView item you have a frozen UI until you double click a second time, ending the loop.

johnathan-becker commented 2 weeks ago

@fredkiefer I am not sure why the pipelines are failing I am getting the message It looks like GNUstep backend is not yet installed

fredkiefer commented 2 weeks ago

Skipping most of the tests is normal in the pipeline. Maybe we should add a step to download and compile back here? But your error is another one:

gui/NSBezierPath/basic.m:
Failed file:  basic.m aborted without running all tests!

But then I have no idea, how your change could affect that.

fredkiefer commented 2 weeks ago

I found and fixed the reason why the NSBezierPath test failed. If you rebase it should be fixed for you as well.

johnathan-becker commented 1 week ago

@fredkiefer I have rebased and all checks have passed now! Thank you.