gnustep / tools-make

The makefile package is a simple, powerful and extensible way to write makefiles for a GNUstep-based project.
https://www.gnustep.org/
GNU General Public License v3.0
28 stars 43 forks source link

Alpine Linux / musl C library support broken at link stage #31

Closed rmottola closed 10 months ago

rmottola commented 1 year ago

We broke build on Alpine Liunx somewhen in the past year. When building base, everything compiles, but links badly. gnustep base itself is not built as a shared library and compiling things like autogsdoc will give missing symbols of a lot of base dependencies (e.g. gz, tls, etc). The issue comes from gnustep make, since checking out older versions with current base, makes a working base.

I tracked it down between these two commits:

Broken:


commit 5dd6aee069089a75ef8ef7a5185dd8fe147f3b8a (HEAD)
Author: Hugo Melder <service@hugomelder.com>
Date:   Tue Aug 2 19:25:07 2022 +0200

    Cleanup config.make.in

Working:

commit fd76f00ab873d73a000f4546e52e1686331cda0c (HEAD)
Author: Richard Frith-Macdonald <rfm@gnu.org>
Date:   Wed Feb 16 09:28:34 2022 +0000

    Unless --failfast is specified, all test files should be executed.
rmottola commented 1 year ago

Already broken:

commit 0dee9266100ff65809c0c4ee7d2e6fcadb6c6b08 (HEAD)
Merge: 5e981820 1e690121
Author: Fred Kiefer <fredkiefer@gmx.de>
Date:   Sun Jun 12 17:20:42 2022 +0200

    Merge pull request #27 from gnustep/config_update

    Use newer version of config.guess and config.sub.
rmottola commented 1 year ago

Still works:

commit 5e9818204bc0d32b31e2fdda4b3030724dec07ce (HEAD)
Author: Richard Frith-Macdonald <rfm@gnu.org>
Date:   Tue Mar 1 13:57:56 2022 +0000

    Avoid output from TestInfo script breaking things
rmottola commented 1 year ago

I identify this a s breaking commit https://github.com/gnustep/tools-make/commit/0dee9266100ff65809c0c4ee7d2e6fcadb6c6b08

hmelder commented 10 months ago

Is the problem still present?

rmottola commented 10 months ago

Fixed by https://github.com/gnustep/tools-make/commit/58d9d3a9e5d86a4f81192845a8634b61166ceb9d