search

gnustep / tools-make

The makefile package is a simple, powerful and extensible way to write makefiles for a GNUstep-based project.
https://www.gnustep.org/
GNU General Public License v3.0
28 stars 43 forks source link

Fix extract class names for runtime2.0 (all OSes) #6

Closed plaurent closed 4 years ago

plaurent commented 4 years ago

This is an attempt to apply the fix that works under Linux for GNUstep Runtime > 2.0 to other operating systems (Darwin, OpenBSD, Mingw32/64).

Needs to be tested for each of those platforms.

plaurent commented 4 years ago

I have now also applied the same @rfm (sed -e -e) strategy for the fixes for other OSes, but I am not currently able to test GNUstep under those other OSes. In theory this should be ready to merge. In practice, it needs to be tested. /cc @davidchisnall @rfm

If https://github.com/gnustep/tools-make/pull/5 gets merged first, let's retarget this pull request to master.

ngrewe commented 4 years ago

I've tested this in-vitro (i.e. plucked the changed nm/sed combinations from the makefile and applied them to some binaries) on Darwin and OpenBSD, and the sed changes for the Mingw variants are roughly equivalent, so I'm fairly confident that we can just address potential follow-up problems in a patch release.

Thanks again Patryk!

plaurent commented 4 years ago

Thank you @ngrewe !!