gnustep / tools-windows-msvc

Objective-C on Windows using Clang and GNUstep.

MIT License

44 stars 10 forks source link

libxml2: Migrate to CMake #48

Closed hmelder closed 4 months ago

hmelder commented 4 months ago

47

triplef commented 4 months ago

Thanks! I added a couple small comments.

What was the reason for requiring Windows-provided ICU with this change? I think it’s fine to do this, but then we should also remove the ICU phase script, and probably mention this requirement further up top in the readme (not in the "building the toolchain" section as it’s both a build- and runtime requirement.

hmelder commented 4 months ago

What was the reason for requiring Windows-provided ICU with this change?

Just out of convenience. I can change it back, but this would require testing correct detection of our ICU build. Should I look into that?

triplef commented 4 months ago

Ok makes sense. I’ve pushed these changes removing ICU to make this more explicit. Can you please rebase onto the latest master?