gnuton / asuswrt-merlin.ng

Extends the support of Merlin firmware to more ASUS routers
Other
1.48k stars 84 forks source link

Advanced_URLFilter does sometimes not apply rules anymore #552

Open Crashdummyy opened 8 months ago

Crashdummyy commented 8 months ago

Router Model Affected DSL-AX82U

Firmware Version Affected 388.6.0

Is this bug present in upstream Merlin releases too? Actually no idea. It worked fine until the update yesterday ( previously on 388.2.0

Describe the bug Updating the list does not alter the content anymore. When I clear the whole list it appears I'm able to introduce new entries again. It has to be something internally because the request looks okayish I guess. ( whats that + doing here? +mediaservices.cdn-apple.com )

The issue appears the moment I try to insert eg "service.idsync.analytics.yahoo.com"

current_page=Advanced_URLFilter_Content.asp & 
next_page=Advanced_URLFilter_Content.asp &
modified=0 &
action_mode=apply &
action_wait=5 &
action_script=restart_firewall &
preferred_lang=EN &
firmver=3.0.0.4 &
url_rulelist=<1>ALL>fb.me
    <1>ALL>fb.com
    <1>ALL>crashlytics.com
    <1>ALL>facebook
    <1>ALL>meta
    <1>ALL>fbcdn
    <1>ALL>oculus
    <1>ALL>fbsbx
    <1>ALL>lgtvcommon
    <1>ALL>discovery.meethue.com
    <1>ALL>lgthinq
    <1>ALL>service.idsync.analytics.yahoo.com
    <1>ALL>nevoai-iothub-54-prod.azure-devices.net
    <1>ALL>+mediaservices.cdn-apple.com
    <1>ALL>lgsmartad &
url_enable_x=0 &
url_mode_x=0 &
url_keyword_x_0=

To Reproduce Steps to reproduce the behavior:

  1. Go to http://router.asus.com/Advanced_URLFilter_Content.asp
  2. Add or delete an entry
  3. Press apply
  4. The previously applied list is still there after an update

Expected behavior The filter List is updated ( Advanced_URLFilter_Content.asp

Screenshots image

gnuton commented 8 months ago

Tested on my DSL-AX82U with 3004.388.6_2-gnuton0_alpha1 and I cannot reproduce it. it works for me. Maybe you have edited your settings and you broke them. Try to reset it

Crashdummyy commented 8 months ago

Tested on my DSL-AX82U with 3004.388.6_2-gnuton0_alpha1 and I cannot reproduce it. it works for me. Maybe you have edited your settings and you broke them. Try to reset it

It's as I wrote. I did reset everything and I am able to configure the list again.

However when I insert service.idsync.analytics.yahoo.com to the list it doesnt get updated anymore. In my case I could successfully insert it on 388.2 leaving the list unchangeable once I upgraded to 388.6.

I don't see any form of validationerror it just doesnt update the list when I try to insert an invalid address

gnuton commented 8 months ago

there is validation for inserted strings. You cannot enter anymore more than 31 chars. image

Crashdummyy commented 8 months ago

Okay I am apparently hitting this limit. I think it'd nice to get some visual feedback and not just this entry not being inserted into that list.