search

gnuton / asuswrt-merlin.ng

Extends the support of Merlin firmware to more ASUS routers
Other
1.42k stars 82 forks source link

Update manifest2.txt to include RT-AX92U #600

Closed ExtremeFiretop closed 3 months ago

ExtremeFiretop commented 3 months ago

Update manifest2.txt to include RT-AX92U (MerlinAU dev router)

image image

Also noticed the webs_update.sh is still complaining about invalid parameters.

ExtremeFiretop commented 3 months ago

@Martinski4Github

For visibility

ExtremeFiretop commented 3 months ago

I tested my change by changing the URL in the webs_update.sh temporarily, and now it correctly detects updates:

image

ExtremeFiretop commented 3 months ago

Also noticed the webs_update.sh is still complaining about invalid parameters.

image

I didn't notice this the first time we tested the script, but at the time were was not updates available.

Martinski4GitHub commented 3 months ago

Update manifest2.txt to include RT-AX92U (MerlinAU dev router)

...

Also noticed the webs_update.sh is still complaining about invalid parameters.

Those are very good catches, bud. It looks like Gnuton is not quite ready yet for MerlinAU until the manifest is fixed, but also particularly because of the issue found with the "merlin_webs_update.sh" script. Until that fix gets merged & distributed with the next F/W release version, MerlinAU may not completely work with Gnuton, but it's getting close.

ExtremeFiretop commented 3 months ago

Update manifest2.txt to include RT-AX92U (MerlinAU dev router) ... Also noticed the webs_update.sh is still complaining about invalid parameters.

Those are very good catches, bud. It looks like Gnuton is not quite ready yet for MerlinAU until the manifest is fixed, but also particularly because of the issue found with the "merlin_webs_update.sh" script. Until that fix gets merged & distributed with the next F/W release version, MerlinAU may not completely work with Gnuton, but it's getting close.

Thank you, agreed. Still a few more touches, what I noticed is that merlins update script has the same issues this one had. The difference is that Gnuton's had -x originally for debugging which we changed to -u so we can see these invalid variables, I'm assuming rmerlins would have the same errors if it had -u or -x.

Either way, so close we can see the light at the end of the tunnel!

Martinski4GitHub commented 3 months ago

Those are very good catches, bud. It looks like Gnuton is not quite ready yet for MerlinAU until the manifest is fixed, but also particularly because of the issue found with the "merlin_webs_update.sh" script. Until that fix gets merged & distributed with the next F/W release version, MerlinAU may not completely work with Gnuton, but it's getting close.

Thank you, agreed. Still a few more touches, what I noticed is that merlins update script has the same issues this one had. The difference is that Gnuton's had -x originally for debugging which we changed to -u so we can see these invalid variables, I'm assuming rmerlins would have the same errors if it had -u or -x.

Yeah, good point. Perhaps, you should report the bug to RMerlin's F/W so the problem gets fixed in both places. Also, when Gnuton gets the latest code for 3006, the fix will be included as well.

ExtremeFiretop commented 3 months ago

Those are very good catches, bud. It looks like Gnuton is not quite ready yet for MerlinAU until the manifest is fixed, but also particularly because of the issue found with the "merlin_webs_update.sh" script. Until that fix gets merged & distributed with the next F/W release version, MerlinAU may not completely work with Gnuton, but it's getting close.

Thank you, agreed. Still a few more touches, what I noticed is that merlins update script has the same issues this one had. The difference is that Gnuton's had -x originally for debugging which we changed to -u so we can see these invalid variables, I'm assuming rmerlins would have the same errors if it had -u or -x.

Yeah, good point. Perhaps, you should report the bug to RMerlin's F/W so the problem gets fixed in both places. Also, when Gnuton gets the latest code for 3006, the fix will be included as well.

I wanted to start with Gnuton because it's the one that had a visible error, but your right. I think I will :) nothing wrong with suggesting some improvements in my eyes.

ExtremeFiretop commented 3 months ago

@gnuton

Made commit: https://github.com/gnuton/asuswrt-merlin.ng/pull/600/commits/52f935a98ed7c794cc7081de40cb578cf0ebd228 To match/sync RMerlins commit here: https://github.com/RMerl/asuswrt-merlin.ng/commit/90a9cc3a53e0415056949e0eec6318bb28244c9a

ExtremeFiretop commented 3 months ago

Those are very good catches, bud. It looks like Gnuton is not quite ready yet for MerlinAU until the manifest is fixed, but also particularly because of the issue found with the "merlin_webs_update.sh" script. Until that fix gets merged & distributed with the next F/W release version, MerlinAU may not completely work with Gnuton, but it's getting close.

Thank you, agreed. Still a few more touches, what I noticed is that merlins update script has the same issues this one had. The difference is that Gnuton's had -x originally for debugging which we changed to -u so we can see these invalid variables, I'm assuming rmerlins would have the same errors if it had -u or -x.

Yeah, good point. Perhaps, you should report the bug to RMerlin's F/W so the problem gets fixed in both places. Also, when Gnuton gets the latest code for 3006, the fix will be included as well.

The equivalent RMerlin PR was opened here: https://github.com/RMerl/asuswrt-merlin.ng/pull/853