search

gnzlbg / static_vector

A dynamically-resizable vector with fixed capacity and embedded storage
https://gnzlbg.github.io/static_vector
167 stars 21 forks source link

size_type should be size_t #30

Closed gnzlbg closed 6 years ago

gnzlbg commented 6 years ago

size_type should be size_t, the type used to storage the vector size is the one that should be "as small as possible".

viboes commented 6 years ago

When will we move to a signed type for size_type?

gnzlbg commented 6 years ago

The STL2 does this for ranges, but nobody has suggesting modernizing the containers for the STL2 yet...

On Sun 29. Oct 2017 at 14:28, Vicente J. Botet Escriba < notifications@github.com> wrote:

When will be move to a signed type for size_type?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gnzlbg/fixed_capacity_vector/issues/30#issuecomment-340262394, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3NpmfiABFad-czEQG5m0h4lvtL70NXks5sxH1jgaJpZM4QKP1O .

viboes commented 6 years ago

Agreed. We will need a paper that changes this for std2.

CaseyCarter commented 6 years ago

the type used to storage the vector size is the one that should be "as small as possible".

...which can be left to QoI.

gnzlbg commented 6 years ago

So this is fixed. @CaseyCarter should that QoI issue be mentioned somewhere? (currently it is not).

CaseyCarter commented 6 years ago

should that QoI issue be mentioned somewhere? (currently it is not)

I wouldn't bother.