search

go-aah / aah

A secure, flexible, rapid Go web framework
https://aahframework.org
MIT License
690 stars 33 forks source link

Generic auth improvements #257

Closed joelsdc closed 4 years ago

jeevatkm commented 5 years ago

@joelsdc Thank you for the PR.

It seem test case is failing, could you have a look https://travis-ci.org/go-aah/aah/jobs/551481914#L384 and address?

codecov[bot] commented 5 years ago

Codecov Report

Merging #257 into master will decrease coverage by 0.16%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   85.53%   85.36%   -0.17%     
==========================================
  Files          94       94              
  Lines        7679     7694      +15     
==========================================
  Hits         6568     6568              
- Misses        771      784      +13     
- Partials      340      342       +2
Impacted Files Coverage Δ
security/authc/authentication_info.go 100% <ø> (ø) :arrow_up:
security.go 81.21% <0%> (-5.81%) :arrow_down:
security/scheme/generic_auth.go 86.66% <0%> (-13.34%) :arrow_down:
security/scheme/base.go 91.3% <100%> (+0.19%) :arrow_up:
security/authc/authentication_token.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update def102f...a0cd923. Read the comment docs.