fix: ensure case-insensitive comparison of CNAME records - Githubissues

go-acme / lego

Let's Encrypt/ACME client and library written in Go

https://go-acme.github.io/lego/

MIT License

7.84k stars 1.01k forks source link

fix: ensure case-insensitive comparison of CNAME records #1956

Closed gryphius closed 1 year ago

gryphius commented 1 year ago

Fixes #1955

Changes:

Modified the updateDomainWithCName function in cname.go to use a case-insensitive comparison (strings.EqualFold). This allows the function to correctly identify the CNAME records irrespective of case.
Added a new unit test TestCnameCaseInsensitive in cname_test.go to validate that the updateDomainWithCName function works correctly when the DNS record is in uppercase.