search

go-acme / lego

Let's Encrypt/ACME client and library written in Go
https://go-acme.github.io/lego/
MIT License
7.84k stars 1.01k forks source link

servercow: fix regression #1964

Closed ldez closed 1 year ago

ldez commented 1 year ago

Fixes #1963

servercow doesn't seem to follow the standard about Content-Type header.

Likewise, the "Content-Type" is explicitly specified here as "application/json"! --- https://cp.servercow.de/client/plugin/support_manager/knowledgebase/view/34/dns-api-v1/7/

ldez commented 1 year ago

ping @jhartlep @jsievertde, can you try the PR?

jsievertde commented 1 year ago

@ldez

So i build my self a version of your fix and now it works again. See attached log message.

2023/07/21 16:28:24 [INFO] [nextcloud.XXX.XX, cloud.XXX.XX, cloudy.XXX.XX] acme: Obtaining bundled SAN certificate
2023/07/21 16:28:25 [INFO] [cloud.XXX.XX] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz-v3/247613631517
2023/07/21 16:28:25 [INFO] [cloudy.XXX.XX] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz-v3/247613631527
2023/07/21 16:28:25 [INFO] [nextcloud.XXX.XX] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz-v3/247648668397
2023/07/21 16:28:25 [INFO] [cloud.XXX.XX] acme: authorization already valid; skipping challenge
2023/07/21 16:28:25 [INFO] [nextcloud.XXX.XX] acme: authorization already valid; skipping challenge
2023/07/21 16:28:25 [INFO] [cloudy.XXX.XX] acme: Could not find solver for: tls-alpn-01
2023/07/21 16:28:25 [INFO] [cloudy.XXX.XX] acme: Could not find solver for: http-01
2023/07/21 16:28:25 [INFO] [cloudy.XXX.XX] acme: use dns-01 solver
2023/07/21 16:28:25 [INFO] [cloudy.XXX.XX] acme: Preparing to solve DNS-01
2023/07/21 16:28:30 [INFO] [cloudy.XXX.XX] acme: Trying to solve DNS-01
2023/07/21 16:28:30 [INFO] [cloudy.XXX.XX] acme: Checking DNS record propagation using [8.8.8.8:53]
2023/07/21 16:28:32 [INFO] Wait for propagation [timeout: 1m0s, interval: 2s]
2023/07/21 16:28:32 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:34 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:36 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:38 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:41 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:43 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:45 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:47 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:49 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:51 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:53 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:55 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:57 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:28:59 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:01 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:03 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:05 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:07 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:09 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:11 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:13 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:15 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:17 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:19 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:21 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:24 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:26 [INFO] [cloudy.XXX.XX] acme: Waiting for DNS record propagation.
2023/07/21 16:29:34 [INFO] [cloudy.XXX.XX] The server validated our request
2023/07/21 16:29:34 [INFO] [cloudy.XXX.XX] acme: Cleaning DNS-01 challenge
2023/07/21 16:29:35 [INFO] [nextcloud.XXX.XX, cloud.XXX.XX, cloudy.XXX.XX] acme: Validations succeeded; requesting certificates
2023/07/21 16:29:36 [INFO] [nextcloud.XXX.XX] Server responded with a certificate.
root@nextcloud:/usr/local/bin# /opt/lego/lego --version
lego version a43bca12bab9075f1cc247d9091f134ffc784b23 linux/amd64