search

go-acme / lego

Let's Encrypt/ACME client and library written in Go
https://go-acme.github.io/lego/
MIT License
7.84k stars 1.01k forks source link

Adding S3 support for HTTP domain validation #1970

Closed kingcdavid closed 1 year ago

kingcdavid commented 1 year ago

PR to allow upload token to S3 for HTTP domain Validation

Fixes #1969 Closes #334

ldez commented 1 year ago

I think you forgot to add the provider code itself.

kingcdavid commented 1 year ago

That's embarrassing, forgot the git add

updated now

ldez commented 1 year ago

I follow your PR and migrate route53 and lightsail to the SDK v2: #1973

ldez commented 1 year ago

I will ask you to provide a command example and the output of this command. (with redacted information :wink:)

ldez commented 1 year ago

@beornf could you try this PR?

kingcdavid commented 1 year ago

I will ask you to provide a command example and the output of this command. (with redacted information :wink: )

$ ./dist/lego -k rsa2048 --domains "<redacted>" --server https://emea.acme.atlas.globalsign.com/directory --kid <redacted> --eab --hmac <redacted>  --http.s3-bucket daveacmetest --http --email <redacted> run 
2023/07/25 13:04:34 [INFO] [<redacted>] acme: Obtaining bundled SAN certificate
2023/07/25 13:04:35 [INFO] [<redacted>] AuthURL: https://emea.acme.atlas.globalsign.com/authz/<redacted>
2023/07/25 13:04:35 [INFO] [<redacted>] acme: use http-01 solver
2023/07/25 13:04:35 [INFO] [<redacted>] acme: Trying to solve HTTP-01
2023/07/25 13:04:41 [INFO] [<redacted>] The server validated our request
2023/07/25 13:04:41 [INFO] [<redacted>] acme: Validations succeeded; requesting certificates
2023/07/25 13:04:42 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2023/07/25 13:04:42 [INFO] [<redacted>] Server responded with a certificate.
ldez commented 1 year ago

can you add a small readme inside the package to explain how to set it up (permissions, expectations, ...)?