search

go-acme / lego

Let's Encrypt/ACME client and library written in Go
https://go-acme.github.io/lego/
MIT License
7.58k stars 994 forks source link

doc: retrieve hugo-theme-learn as hugo module #1994

Closed deining closed 11 months ago

deining commented 11 months ago

This PR changes: the way the documentation is created: hugo-theme-learn ist now pulled in as hugo module. This is the newer and more elegant way to use hugo theme components.

ldez commented 11 months ago

Hello,

it was a choice to not use the hugo module system, when I added the theme the hugo module system was already existing.

deining commented 11 months ago

Hello,

it was a choice to not use the hugo module system, when I added the theme the hugo module system was already existing.

I see. I respect your decision. Out of interest: may I ask why you deliberately didn't use the hugo module system?

ldez commented 11 months ago

Even if I really appreciate Hugo, I encounter several problems. The zerover approach is a problem. I was a long-time user and at some point, I was tired of breaking changes and the choice of standard or extended version. This PR is a good example: https://github.com/go-acme/lego/actions/runs/5901899017/job/16011104875?pr=1994

The hugo module system is pretty much the same thing. The git submodule was a bad solution for me, and I never use it. When the hugo modules appear I was thinking that was a solution but I "fought" against themes that have some Go files in them. At this time, the Go modules were new, and hugo modules too. It was not a good experience so I decided to use a simple git clone.

But maybe it's time to evaluate again the hugo modules.

I have a question completely off-topic: you feel like a "Hugo evangelist", and I need to replace the way to build the documentation for another opensource project (but I need to keep the style and several other things), are you interested to help me on that?

deining commented 11 months ago

I have a question completely off-topic: you feel like a "Hugo evangelist",

I wouldn't say that. I use hugo for documentation purposes and like it, but I clearly see the deficencies (as you!).

and I need to replace the way to build the documentation for another opensource project (but I need to keep the style and several other things), are you interested to help me on that?

I need to know a bit more background to give an answer here. Feel free to write me privately (see my GitHub profile) and tell me a bit more about your project, your needs and your plans.

ldez commented 11 months ago

There is nothing private :smile:, it is just a question to know if it's something possible. I need to talk with the maintainers of this project before.

deining commented 11 months ago

There is nothing private 😄, it is just a question to know if it's something possible.

Yes it is. No promise, though.

I need to talk with the maintainers of this project before.

Keep me informed.

deining commented 11 months ago

But maybe it's time to evaluate again the hugo modules.

After bumping to latest hugo version, checkers are green now :smile:.