Closed jakdept closed 9 months ago
Hello,
Why did you change the prefix?
All the PR should be rewritten to:
I will rewrite it.
I changed the prefix so it matches our terraform provider and upcoming prefix for the CLI and other tooling. However, I changed it in a way so that the old prefix still works. I believe I have tests showing that as well.
I did not see anything specifying a standard around the prefix. If that's an issue, we can leave it as LIQUID_WEB_
and I can work around it, but it's going to differ from all other tooling we provide.
I will merge the PR without the LWAPI_
.
I will extend the system I created to handle fallback env vars for the cloudflare provider to be usable in this context.
I will create a PR with the support of LWAPI_
with the right fallback system.
I work for LiquidWeb, and we'd like to get some updates into our provider in lego to simplify things a bit and change the API endpoint.
I've followed the guidelines at https://github.com/go-acme/lego/blob/2140e6befe2a46267c88c735a40f4791fe6036ab/CONTRIBUTING.md and will open an issue as well once I've got this open.
I'm skipping including
make test
cause of the long output, but it passes as well.I'm guessing you'll squash my commits, which is fine if needed. Or I can submit another and squash them myself if needed.