Update CertID format as per draft-ietf-acme-ari-02

go-acme / lego

Let's Encrypt/ACME client and library written in Go

https://go-acme.github.io/lego/

MIT License

7.46k stars 986 forks source link

Update CertID format as per draft-ietf-acme-ari-02 #2066

Closed beautifulentropy closed 5 months ago

beautifulentropy commented 7 months ago

Implemented the updated CertID format as specified in draft-ietf-acme-ari-02.
Removed the --ari-hash-name flag, which is no longer necessary with the updated format.
Enabled ARI usage for users with --no-bundle option. Previously, this was not possible as the draft-ietf-acme-ari-01 format required metadata available only in the issuer.

ATTENTION: this must NOT be merged and should remain in draft until https://github.com/letsencrypt/boulder/pull/7184 is merged and deployed.

UPDATE: this change has been merged, but it will not be deployed to Production until a few days into the new year. I'll update this issue when that's the case.

beautifulentropy commented 7 months ago

I recall this same failure in #1912 which added inital support for ARI:

Error: cmd/cmd_renew.go:128:1: cyclomatic complexity 15 of func `renewForDomains` is high (> 12) (gocyclo)
func renewForDomains(ctx *cli.Context, client *lego.Client, certsStorage *CertificatesStorage, bundle bool, meta map[string]string) error {
^
make: *** [Makefile:36: checks] Error 1
Error: Process completed with exit code 2.

ldez commented 7 months ago

for now, you can ignore the linter about cyclomatic complexity, I will look at the best way to handle that.

ldez commented 5 months ago

I fixed the problem of cyclomatic complexity. Just waiting for the deployment to Production.

beautifulentropy commented 5 months ago

I fixed the problem of cyclomatic complexity. Just waiting for the deployment to Production.

Thanks for fixing this @ldez. Just checked our SRE team and support for this portion of draft-ietf-acme-ari-02 has been successfully deployed to both staging and production.

ldez commented 5 months ago

Maybe you can set the PR as "Ready for review"?