go-acme / lego

Let's Encrypt/ACME client and library written in Go
https://go-acme.github.io/lego/
MIT License
7.91k stars 1.01k forks source link

Please release Azure OIDC support #2070

Closed adeturner closed 9 months ago

adeturner commented 9 months ago

Welcome

What did you expect to see?

Github actions Azure Federated Identity OIDC authentication is not compatible with the current release of Lego.

It is fixed in #2036 azuredns: allow oidc authentication has been merged but does not seem to be in a release yet

Please can you create release so vancluever/terraform-provider-acme can be updated.

See also https://github.com/vancluever/terraform-provider-acme/pull/352#issuecomment-1846653431

Sorry - probably shouldn't be a bug and the feature has already been added, so guess its more of a request

What did you see instead?

code = Unknown desc = azuredns: DefaultAzureCredential authentication failed

How do you use lego?

Through Terraform ACME provider

Reproduction steps

resource "acme_certificate" "cert" {
  account_key_pem = acme_registration.,mycert[0].account_key_pem
  common_name     = var.myname

  dns_challenge {
    # https://registry.terraform.io/providers/vancluever/acme/latest/docs/guides/dns-providers-azuredns
    provider = "azuredns"
    config = {
      AZURE_AUTH_METHOD         = "oidc"
      AZURE_RESOURCE_GROUP      = var.public_dns_rg
      AZURE_ZONE_NAME           = var.public_dns_zone
      AZURE_CLIENT_ID           = data.azurerm_client_config.current.client_id
      AZURE_SUBSCRIPTION_ID     = data.azurerm_client_config.current.subscription_id
      AZURE_TENANT_ID           = data.azurerm_client_config.current.tenant_id
      AZURE_TTL                 = 300
      AZURE_PROPAGATION_TIMEOUT = 150
    }
  }
}

Version of lego

github.com/go-acme/lego/v4 v4.14.2

Logs

code = Unknown desc = azuredns: DefaultAzureCredential authentication failed

Go environment (if applicable)

n/a