go-acme / lego

Let's Encrypt/ACME client and library written in Go
https://go-acme.github.io/lego/
MIT License
7.46k stars 986 forks source link

Misleading log output #2097

Closed alxndr13 closed 5 months ago

alxndr13 commented 5 months ago

Welcome

What did you expect to see?

Would expect to see something like:

2024/01/31 16:15:28 [INFO] [*.example.com] acme: Checking DNS record propagation using the authoritive nameservers and 1.1.1.1...

as after printing this log line, we're calling the preCheck.call() func, which in turn calls the checkDNSPropagation where only the INITIAL dnsQuery is sent to the recursive nameservers. if that is good, we're checking the authoritive nameservers but this part is missing from the log line and may be misleading and lets the user believe only 1.1.1.1 is needed for a proper dns propagation..

What did you see instead?

lego prints a line in the logs like this:

2024/01/31 16:15:28 [INFO] [*.example.com] acme: Checking DNS record propagation using [1.1.1.1:53 8.8.8.8:53 9.9.9.9:53]

How do you use lego?

Library

Reproduction steps

  1. Use the Library example code
  2. see the log

Version of lego

v4.15.0

Logs

see expected output

Go environment (if applicable)

No response