Implement 'replaces' field in newOrder and draft-ietf-acme-ari-03 CertID changes

go-acme / lego

Let's Encrypt/ACME client and library written in Go

https://go-acme.github.io/lego/

MIT License

7.44k stars 987 forks source link

Implement 'replaces' field in newOrder and draft-ietf-acme-ari-03 CertID changes #2114

Closed beautifulentropy closed 3 months ago

beautifulentropy commented 4 months ago

Implement the updated CertID formation, as per draft-ietf-acme-ari-03.
Implement the "replaces" field in newOrder for indicating an order is a replacement at renewal time, as per draft-ietf-acme-ari-03.
Discontinue and remove the POST method implementation for indicating replacement success, deprecated in draft-ietf-acme-ari-03.

https://datatracker.ietf.org/doc/draft-ietf-acme-ari/

PLEASE NOTE: this MUST NOT be merged until https://github.com/letsencrypt/boulder/pull/7298 is deployed to Production. I'll keep this issue up-to-date.

beautifulentropy commented 4 months ago

This is expected and has occurred in the two previous ARI PRs that touch renewForDomains.

Error: cmd/cmd_renew.go:128:1: cyclomatic complexity 14 of func `renewForDomains` is high (> 12) (gocyclo)
func renewForDomains(ctx *cli.Context, client *lego.Client, certsStorage *CertificatesStorage, bundle bool, meta map[string]string) error {

ldez commented 4 months ago

The current failure of the CI is related to a Pebble bug, I fixed the problem inside #2119. So I will just rebase your PR to pass the CI.

beautifulentropy commented 4 months ago

@ldez the changes necessary to support this contribution have been deployed at Let's Encrypt. Let me know if you need anything else.

ldez commented 3 months ago

I missed the conflict :cry: