make overallRequestLimit an option

go-acme / lego

Let's Encrypt/ACME client and library written in Go

https://go-acme.github.io/lego/

MIT License

7.44k stars 985 forks source link

make overallRequestLimit an option #2203

Closed fernsehmuell closed 2 weeks ago

fernsehmuell commented 3 weeks ago

Welcome

[X] Yes, I've searched similar issues on GitHub and didn't find any.

How do you use lego?

Binary

Detailed Description

Hello, we use lego to get certificates from zerossl. I had to change the hardcoded const overallRequestLimit in certificate/authorization.go I suggest making this an option for the cli. Something like --overallRequestLimit 6

Thanks!

ldez commented 3 weeks ago

hello,

can you explain why you need to change this value?

fernsehmuell commented 3 weeks ago

Hello ldez, because i ran into the rate limit of zerossl, which seems to be lower than the one of let's encrypt.

ldez commented 2 weeks ago

I'm trying to find the relevant ZeroSSL doc but I found nothing, it's annoying.

ldez commented 2 weeks ago

I found the doc:

https://help.zerossl.com/hc/en-us/articles/17864245480093-Advantages-over-Using-Let-s-Encrypt#h_01HT4Z1JCJFJQFJ1M3P7S085Q9

	LE	ZeroSSL
Overall Requests per second Limit on the number of API requests per second for endpoints (e.g., new cert, revoke cert).	20	REST API - none ACME - 7