designate: allow manually overwriting DNS zone

go-acme / lego

Let's Encrypt/ACME client and library written in Go

https://go-acme.github.io/lego/

MIT License

7.44k stars 985 forks source link

designate: allow manually overwriting DNS zone #2204

Open jan-di opened 3 weeks ago

jan-di commented 3 weeks ago

This is basically the same feature as in #1433 for the OpenStack Designate provider.

This solves problems that occur in situations like SplitDNS/Private DNS Zones where the automatic SOA detection might not work to the full extend. When setting the Zone Name via environment, it specifically uses this Zone Name when communicating with the Designate API. Otherwise, nothing changes.

jan-di commented 1 day ago

@ldez Thank you for refactoring! I'm not that fluent in golang :-)

Is there anything else I should do or what is needed from me?