go-acme / lego

Let's Encrypt/ACME client and library written in Go
https://go-acme.github.io/lego/
MIT License
8.05k stars 1.02k forks source link

Also need to provide an email when using EAB #2265

Closed rea1shane closed 2 months ago

rea1shane commented 2 months ago

Welcome

What did you expect to see?

When using EAB, no need to provide an email. I think email and EAB only need to provide one. Please correct me if I'm not understanding correctly.

What did you see instead?

When using EAB, also need to provide an email.

Get the email directly without checking EAB first.

  1. https://github.com/go-acme/lego/blob/v4.18.0/cmd/cmd_run.go#L83
  2. https://github.com/go-acme/lego/blob/v4.18.0/cmd/accounts_storage.go#L72
  3. https://github.com/go-acme/lego/blob/v4.18.0/cmd/setup.go#L88

Version of lego

v4.18.0
ldez commented 2 months ago

Duplicate of #277

rea1shane commented 2 months ago

Duplicate of #277

I think the two issues are different