search

go-actions / linked-issues

Find the issues linked with a Pull Request
MIT License
7 stars 0 forks source link

Refactor code base #2

Closed hossainemruz closed 2 years ago

hossainemruz commented 2 years ago

Signed-off-by: hossainemruz hossainemruz@gmail.com

Ismoh commented 2 years ago

Any news on this @hossainemruz ?

hossainemruz commented 2 years ago

This PR do not add any new features. It's just improves the code quality. It was part of my learning to clean code 😀. Can't remember why I didn't merge it. I will check again.

Ismoh commented 2 years ago

Ah okay! I had a look on the source code and was wondering, how you get the linked issues. Because I need to get access to the development section of a pull request on the top right corner. Maybe we can have a chat somehwere.

hossainemruz commented 2 years ago

Sure. I am on GMT+6 time zone.

Ismoh commented 2 years ago

Well, I prefer chatting on Discord. GMT+2 But besides that, I am thinking to fork your repo and doing changes regarding #3 and adding an additional output like "error" or even better: "requirements": "There are no issues set on 'development'!" If you prefer a different wording, let me know!

So before parsing and finding an issue on html source, there need to be a check, if there are one or more issues linked to this pull request.

In addition to this let me know, which branch should be base_ref, when creating contributer pull request!

hossainemruz commented 2 years ago

Hi @Ismoh. I have merged the changes in main branch. You can do a PR against the main branch. If you need to discuss anything, feel free to open a discussion or provide a link where we can discuss.

Ismoh commented 2 years ago

Going to have a look the next days!