search

go-ap / activitypub

ActivityPub vocabulary for Go
MIT License
124 stars 10 forks source link

Factored out the objects' common properties #6

Closed mariusor closed 5 years ago

mariusor commented 5 years ago

I'm not sure if this is a good way of having more streamlined structs.

So far everything works, buuuut, somehow it feels icky...

codecov[bot] commented 5 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   47.99%   47.99%           
=======================================
  Files          25       25           
  Lines        3742     3742           
=======================================
  Hits         1796     1796           
  Misses       1820     1820           
  Partials      126      126
Impacted Files Coverage Δ
activitystreams/object.go 77.92% <ø> (ø) :arrow_up:
activitypub/shares.go 0% <0%> (ø) :arrow_up:
activitypub/following.go 0% <0%> (ø) :arrow_up:
activitypub/followers.go 0% <0%> (ø) :arrow_up:
activitypub/likes.go 0% <0%> (ø) :arrow_up:
activitystreams/activity.go 98.12% <100%> (ø) :arrow_up:
activitypub/liked.go 43.9% <100%> (ø) :arrow_up:
activitystreams/actors.go 68.58% <100%> (ø) :arrow_up:
activitypub/inbox.go 33.96% <100%> (ø) :arrow_up:
activitypub/outbox.go 43.13% <100%> (ø) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1955b6a...269c06f. Read the comment docs.