search

go-audio / aiff

Battle tested aiff decoder/encoder
Apache License 2.0
26 stars 6 forks source link

increasing test coverage and vgo support #2

Closed glaslos closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #2 into master will increase coverage by 1.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage    52.6%   53.68%   +1.08%     
==========================================
  Files           6        6              
  Lines         730      732       +2     
==========================================
+ Hits          384      393       +9     
+ Misses        252      245       -7     
  Partials       94       94
Impacted Files Coverage Δ
chunk.go 75.55% <100%> (+17.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c3a8a6...54807fb. Read the comment docs.

mattetti commented 6 years ago

Interesting, I didn't realize we had a dependency on github.com/mattetti/audio that's probably something we should remove

glaslos commented 6 years ago

@mattetti you would need to move the riff package from your personal account to go-audio in order to resolve that dependency.

mattetti commented 6 years ago

Ahh makes sense, I should definitely do that!

On Sat, Oct 13, 2018, 13:34 Lukas Rist notifications@github.com wrote:

@mattetti https://github.com/mattetti you would need to move the riff package from your personal account to go-audio in order to resolve that dependency.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/go-audio/aiff/pull/2#issuecomment-429573154, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAAcR8xHW0WMEP3mgX1z8fcg-W1wVwUks5ukk43gaJpZM4Xax8_ .