search

go-audio / wav

Battle tested Wav decoder/encoder
Apache License 2.0
300 stars 46 forks source link

basic changes for vgo support #15

Closed glaslos closed 5 years ago

glaslos commented 5 years ago

A couple of changes and additions to make vgo work. I had to put all tests into the wav package to make vgo happy.

codecov-io commented 5 years ago

Codecov Report

Merging #15 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   58.84%   58.84%           
=======================================
  Files           6        6           
  Lines         622      622           
=======================================
  Hits          366      366           
  Misses        160      160           
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87c13ac...c544d35. Read the comment docs.

mattetti commented 5 years ago

Ohh that's a bummer but thanks so much for adding support for vgo!

dmitshur commented 5 years ago

I had to put all tests into the wav package to make vgo happy.

What was the error you're getting? Which version of Go were you using? I don't think that should be the case.

glaslos commented 5 years ago

I was using vgo with 1.10. Issue was that vgo tried to import the wav_test package and couldn't find it.

dmitshur commented 5 years ago

I see. I suspect it's a bug in 1.10 but has been fixed in Go 1.11.

You could confirm that if you'd like, then this change could be reversed if support for Go 1.11 is sufficient.