search

go-bdd / gobdd

BDD framework
https://go-bdd.github.io/gobdd/
MIT License
115 stars 19 forks source link

Do not discard log output #129

Closed zippolyte closed 3 years ago

zippolyte commented 3 years ago

There might be a good reason behind this that I'm not aware of, but this has been tripping me up because our things under test have a debug mode that logs very useful information to determine the cause of the test failure, which just wouldn't be printed when using gobdd.

I have a workaround in place to reset the log output to stderr in a WithBeforeScenario step, but that'd be awesome to just have it working and avoid surprises and debugging time in the future 😅.

Thanks for considering this

bkielbasa commented 3 years ago

pls fix the code and I'll merge it

zippolyte commented 3 years ago

Done ✅

bkielbasa commented 3 years ago

@zippolyte thank you for your collaboration!