search

go-bdd / gobdd

BDD framework
https://go-bdd.github.io/gobdd/
MIT License
115 stars 19 forks source link

Use both feature and scenario tags in skipScenario #132

Closed jirikuncar closed 3 years ago

jirikuncar commented 3 years ago

Currently the feature tags are not taken into account when determining if a scenario should be executed or not.

This should allow positive filtering which is different from skip.

bkielbasa commented 3 years ago

thanks for your submission! Could you add a test for it as well?

jirikuncar commented 3 years ago

It seems like it should work thanks to https://github.com/go-bdd/gobdd/blob/master/gobdd.go#L302-L307. I will investigate more why it was failing for me.

jirikuncar commented 3 years ago

@bkielbasa I have added new test scenarios.

bkielbasa commented 3 years ago

thanks for your PR, merging :)