go-bdd / gobdd

BDD framework
https://go-bdd.github.io/gobdd/
MIT License
115 stars 19 forks source link

Merge context package with the main package #96

Closed sagikazarmark closed 4 years ago

sagikazarmark commented 4 years ago

Is your feature request related to a problem? Please describe. Currently the stdlib context and gobdd context packages can only be used in one file together with import aliases.

Describe the solution you'd like Merge the context package with the main package. The functionality belongs closely together anyway.

Describe alternatives you've considered Create an interface in the main package (interfaces belong to consumers).

Related #83

Additional context This could be a backwards compatible change: we could keep the original package and add a type alias pointing to the new type in the root package.

bkielbasa commented 4 years ago

the context was moved to his own package because I had problems with testhttp package. Go doesn't permit import cycles. We removed the testhttp package from the main repository so IMO we can go for it.