go-bridget / twirp-swagger-gen

A Twirp RPC Swagger/OpenAPI 2.0 generator
Apache License 2.0
50 stars 12 forks source link

protoc plugin support, fix timestamp, add path prefix support #3

Closed melias122 closed 2 years ago

melias122 commented 2 years ago

I can separate this to multiple PRs if needed.

titpetric commented 2 years ago

I stopped reviewing after about 5 commits, I feel like I've learned enough about you to sign off on the rest without looking. Excellent work!

melias122 commented 2 years ago

Sounds good then.

Martin Elias

On 16 Dec 2021, at 16:24, Tit Petric @.***> wrote:

 @titpetric commented on this pull request.

In example/simple/google_timestamp.swagger.json:

@@ -17,6 +17,9 @@ "host": "test.example.com", "paths": {}, "definitions": {

  • "com.exampleEmpty": { "import com.google.protobuf.Timestamp" existing in public code/docs leads me to believe that a dot is the established practice here. I'm gonna add an issue to implement this separately.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.