go-bridget / twirp-swagger-gen

A Twirp RPC Swagger/OpenAPI 2.0 generator
Apache License 2.0
50 stars 12 forks source link

Add dot to object definitions separating <namespace> and <message> #5

Closed titpetric closed 2 years ago

titpetric commented 2 years ago

Currently, the various type references are generated with <namespace><entry> e.g. com.google.protobufTimestamp. Code in the wild seems to suggest that using "." is correct. Asuming the original twirp swagger gen had implemented this incorrectly, we can fix this.

titpetric commented 2 years ago

Implemented package and RPC separation, need to actually verify that packages like apm.v1 somehow make sense for twirp. Any feedback is welcome, but I'm gonna close this for now. The examples/ folder has illustrative output.