Use SendMessageV2 everywhere

go-chat-bot / bot

IRC, Slack, Telegram and RocketChat bot written in go

MIT License

826 stars 195 forks source link

Use SendMessageV2 everywhere #116

Closed toolateforteddy closed 5 years ago

toolateforteddy commented 5 years ago

This isn't necessary everywhere, but for standardization, I thought it would be good to really deprecate SendMessageV1.

The place this IS needed is in PeriodicCommands v2 and PassiveCommands V2. In both those places, objects come back from the caller with ProtoParams that should be forwarded through to the message sending.

coveralls commented 5 years ago

Coverage increased (+0.3%) to 97.248% when pulling fcc799fc3e44130b1a571c4a421bb4438c503476 on toolateforteddy:useSendV2Everywhere into 51bcba0468630bfec578c5dbeef675f3dbbee567 on go-chat-bot:master.

fabioxgn commented 5 years ago

@toolateforteddy I agree with deprecated V1. Thanks for the PR.