WIP: Fix Slack connection + add some improvements

badnetmask commented 1 year ago

This PR fixes some problems, and adds some improvements.

This is still a work in progress because I'm still testing (live) and tweaking the code. There is a TODO list at the end as well. However I would like to pre-submit this PR so that the maintainers can take a look and start their review, while I'm still in "developer mode".

Slack moved away from RTM API, but moving into the Events API would require some heavy re-write, so I added a small patch to make it work for the time being.
I've been a long time user of the Google Chat plugin, and I liked the fact that I could look at the logs and see how people interact with the bot, so I added that feature to the Slack plugin as well (SLACK_VERBOSE).
Since I'm using the same bot binary to connect to both Slack and Google Chat at the same time, I found out that the Jira plugin was breaking the bot because it was trying to send the same message to both protocols at the same time. For that reason, I added a check on the outgoing messages of both Slack and Google Chat plugins to make sure the messages only go to them if the destination has the appropriate/expected format. There is probably a better way to do that, but this is the only way I could find without being too invasive.

Please, let me know your thoughts.

TODO, before this PR can be merged:

Document how to create a "classic" Slack bot that uses the RTM API.
Document how to use the VERBOSE and DEBUG options.
Document the weird Markdown workaround.

fabioxgn commented 1 year ago

Thanks for the PR @badnetmask code looks good, please let me know when it's ready to merge.

badnetmask commented 6 months ago

@fabioxgn -- due to changes in circumstances, I'm no longer maintaining a bot using this code, which means I cannot guarantee it's maintenance going forward. I would leave it for you to choose whether or not to merge this. I'm sorry for the inconvenience.

fabioxgn commented 6 months ago

Hi @badnetmask I'm also not maintaining this project anymore since Heroku killed free dynos, I should probably make this repo read-only because I think most dependencies are outdated, and probably no one is using this project at this time.

So I'm gonna close this PR, thanks!

go-chat-bot / bot

WIP: Fix Slack connection + add some improvements #142