search

go-chat-bot / bot

IRC, Slack, Telegram and RocketChat bot written in go
MIT License
824 stars 194 forks source link

Support for multiple periodic commands #50

Closed zachomedia closed 7 years ago

zachomedia commented 7 years ago

Adds the ability to have multiple periodic commands registered.

fabioxgn commented 7 years ago

The build broke with a race condition, can you please run the tests with -race flag and fix it? Thanks.

Why the startPeriodicCommands() needs to be async? It just registers the commands on cron, right? I guess that it very fast and will not hang the bot's initializaton.

zachomedia commented 7 years ago

@fabioxgn Sorry about that, still new to go. I changed startPeriodicCommands to not be async anymore.

fabioxgn commented 7 years ago

@zachomedia thanks, please send a new PR when you are done.

I also noticed that some plugins are broken and were breaking the build, so I removed then from the build process, will try to fix the build process in the PRs which are broken.

zachomedia commented 7 years ago

PR #51 submitted with the fix