search

go-check / check

Rich testing for the Go language
Other
696 stars 182 forks source link

go module instead of gopkg.in #108

Closed piotrkowalczuk closed 5 years ago

piotrkowalczuk commented 5 years ago

Gopkg.in is down for a few days already. This PR introduces v2 sub-module that can be imported like github.com/go-check/check/v2.

Additionally, it brings some linting/static analysis fixes for problems reported by staticcheck, unused, gosimple and go vet.

niemeyer commented 5 years ago

There hasn't been an outage in gopkg.in for a very long time.

image

For now we'll use Go modules in addition to gopkg.in, not instead of.

niemeyer commented 5 years ago

Note that there was a major outage in GitHub itself yesterday:

https://twitter.com/search?q=github%20outage

piotrkowalczuk commented 5 years ago

@niemeyer Something is clearly wrong here. My project uses modules as well. Once I add check "gopkg.in/check.v1" import go install fails with error:

build xxxx: cannot find module for path gopkg.in/check.v1