search

go-chi / chi

lightweight, idiomatic and composable router for building Go HTTP services
https://go-chi.io
MIT License
18.34k stars 983 forks source link

Collateral damage when upgrading to version 5.0.8 with Datadog #816

Closed luca147 closed 12 months ago

luca147 commented 1 year ago

Hello, we have our healtcheck over / for example: http://xx.xx.xxx.xx:8080/ and also we use Datadog with the go-tracer implementation.

But after upgrade go-chi from 5.0.7 to 5.0.8, our resource dashboard found a unknown new entry. This is cause because this

https://github.com/go-chi/chi/blob/77d709fcde559ca625d4e126478835a0e85d79a9/context.go#L126

I think one solution to keep find the / route valid is only trim the dash if have a route like this /example/

What you think?

luca147 commented 12 months ago

Solved here