Switch to Go 1.7 and 1.8

go-clang / gen

Generate Go bindings for Clang's C API

https://pkg.go.dev/github.com/go-clang/gen

BSD 3-Clause "New" or "Revised" License

44 stars 5 forks source link

Switch to Go 1.7 and 1.8 #142

Closed zimmski closed 4 years ago

zimmski commented 7 years ago

We are only supporting the two latest major Go releases.

This PR has a partner https://github.com/go-clang/bootstrap/pull/18 both have to pass.

coveralls commented 7 years ago

Coverage remained the same at 0.347% when pulling ccb16cf96365850d5b869bdd648f4727ee156c43 on support-1.7-and-1.8 into 4c71f431558629447e4b4fbd5546add275d3957b on master.

zimmski commented 7 years ago

This is odd, Go 1.7 passes but 1.8 fails:

/usr/bin/ld: cannot find -lclang
clang: error: linker command failed with exit code 1 (use -v to see invocation)

zimmski commented 7 years ago

I can reproduce this locally. Maybe this is related to https://github.com/onsi/ginkgo/pull/337 since they are talking about builds taking longer than usual with 1.8. That is the case with this PR too.

zimmski commented 7 years ago

Btw. this went from 1.75s passing to 73.45s failing.

coveralls commented 7 years ago

Coverage remained the same at 0.347% when pulling 37559835f66ffcc8c1c96e73a254ad0e363a82cf on support-1.7-and-1.8 into 4c71f431558629447e4b4fbd5546add275d3957b on master.